Re: [patch 3/5] KVM: add kvm_follow_page()

Avi Kivity
2007-12-24T14:36:32Z

Marcelo Tosatti wrote:
>
>> I believe that a new get_users_pages_inatomic() is more suitable;
>> Andrew, I'll write it if you agree. Alternatively, walk_page_range()
>> should take the lock itself, otherwise it is only usable if you don't
>> care about correctness?
>>
>
> Why not just export follow_page() ? That is exactly what KVM needs.
>
>

Well, follow_page() needs the vma, and doesn't support large pages.
It's too low-level to be a public API.

--
error compiling committee.c: too many arguments to function