Re: [patch 3/5] KVM: add kvm_follow_page()

Marcelo Tosatti
2007-12-23T19:14:03Z

On Sun, Dec 23, 2007 at 10:41:07AM +0200, Avi Kivity wrote:
> Avi Kivity wrote:
> >
> > Exactly. But it is better to be explicit about it and pass the page
> > directly like you did before. I hate to make you go back-and-fourth,
> > but I did not understand the issue completely before.
> >
>
> btw, the call to gfn_to_page() can happen in page_fault() instead of
> walk_addr(); that will reduce the amount of error handling, and will
> simplify the callers to walk_addr() that don't need the page.

But the gfn in question is only known at walk_addr() time, so thats not
possible.