From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [patch 3/5] KVM: add kvm_follow_page() Date: Mon, 24 Dec 2007 09:28:08 -0500 Message-ID: <20071224142808.GB20275@dmt> References: <20071221001821.029994250@redhat.com> <20071221002024.345682789@redhat.com> <476D68A3.3000200@qumranet.com> <20071223052513.GA19072@dmt> <476E083B.5040600@qumranet.com> <476E1F23.3020609@qumranet.com> <20071223191403.GA14035@dmt> <476F56A5.2020607@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-devel To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <476F56A5.2020607-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Mon, Dec 24, 2007 at 08:50:13AM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > >On Sun, Dec 23, 2007 at 10:41:07AM +0200, Avi Kivity wrote: > > > >>Avi Kivity wrote: > >> > >>>Exactly. But it is better to be explicit about it and pass the page > >>>directly like you did before. I hate to make you go back-and-fourth, > >>>but I did not understand the issue completely before. > >>> > >>> > >>btw, the call to gfn_to_page() can happen in page_fault() instead of > >>walk_addr(); that will reduce the amount of error handling, and will > >>simplify the callers to walk_addr() that don't need the page. > >> > > > >But the gfn in question is only known at walk_addr() time, so thats not > >possible. > > > > It's just walker->gfn; certainly it is known in page_fault(). Oh, you mean to grab walker->gfn before fetch() ? Yeah, that makes sense. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/