From: Marcelo Tosatti <marcelo-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>
To: Carlo Marcelo Arenas Belon
<carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] MMU: fix cmpxchg8b emulation on i386 to use the right address
Date: Fri, 4 Jan 2008 07:09:47 -0500 [thread overview]
Message-ID: <20080104120947.GA28608@dmt> (raw)
In-Reply-To: <20080104074204.GA9968@tapir>
On Fri, Jan 04, 2008 at 01:42:04AM -0600, Carlo Marcelo Arenas Belon wrote:
> On Fri, Jan 04, 2008 at 12:57:49AM -0600, Carlo Marcelo Arenas Belon wrote:
> > change the function parameter to use vaddr instead of addr to avoid a
> > variable name redefinition from 9a5ee611ca79bec98e9d97e93f11df8083b8af6e
>
> this implementation has been already patched 6 times (not including this one)
> since it was originally introduced in Dec 12, including compilation and logic
> fixes as can be seen by :
>
> 24a673eb377069509e8dad5ff7fa146e363df739
> eb9270cee7061e5a985eb9eac559270292b1d7ec
> a5e8e8a4f7ddb211d856eb30e93e70af9d51b735
> d5855a0ec163afd591f272e13e1f2c366794306f
> 9bfdd08f0a65e67d0842ca35516669bec523fbe0
> 91051a4955255317cab0d09d8849ec12db85f924
>
> it was meant to fix some sort of bug on i386 because it wasn't atomic but
> with so many changes I am not sure if what it was meant to do has been really
> preserved, so I think it would be better if anyone with more experience and a
> better understanding of this patch could sheed some light on this.
It is OK now. The first patch was quite broken, thus so many fixes :(
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-01-04 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 6:57 [PATCH] MMU: fix cmpxchg8b emulation on i386 to use the right address Carlo Marcelo Arenas Belon
2008-01-04 7:42 ` Carlo Marcelo Arenas Belon
2008-01-04 12:09 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104120947.GA28608@dmt \
--to=marcelo-bw31mazkks3ytjvyw6ydsg@public.gmane.org \
--cc=carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox