Re: [PATCH] QEMU KVM balloon support

[Marcelo Tosatti <marcelo-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>]

On Tue, Jan 08, 2008 at 04:43:42PM +0000, Daniel P. Berrange wrote:
> On Tue, Jan 08, 2008 at 01:43:40PM -0200, Marcelo Tosatti wrote:
> > Index: kvm-userspace/qemu/monitor.c
> > ===================================================================
> > --- kvm-userspace.orig/qemu/monitor.c
> > +++ kvm-userspace/qemu/monitor.c
> > @@ -1339,6 +1339,8 @@ static term_cmd_t term_cmds[] = {
> >        "", "cancel the current VM migration" },
> >      { "migrate_set_speed", "s", do_migrate_set_speed,
> >        "value", "set maximum speed (in bytes) for migrations" },
> > +    { "setmem", "s", do_setmemory, "value", 
> > +      "set memory for the guest (in bytes)" },
> >      { NULL, NULL, },
> >  };
> 
> [snip]
> 
> > +void do_setmemory(const char *value)
> > +{
> > +	int target_ramsize;
> > +	char *ptr;
> > +
> > +	target_ramsize = strtol(value, &ptr, 10);
> > +	switch (*ptr) {
> > +	case 'G': case 'g':
> > +		target_ramsize *= 1024;
> > +	case 'M': case 'm':
> > +		target_ramsize *= 1024;
> > +	case 'K': case 'k':
> > +		target_ramsize *= 1024;
> > +	default:
> > +		break;
> > +	}
> > +
> > +	if (target_ramsize > ram_size) {
> > +		term_printf("Invalid RAM size, maximum: %d\n", ram_size);
> > +		return;
> > +	}
> > +	
> > +	balloon_update_target(target_ramsize);
> > +}
> 
> Shouldn't this use  int64, and strtoll(), otherwise you'll wrap
> at the 2 GB mark ?

Good catch, thanks.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace