From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: "kvm-devel"
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: [PATCH] virtio: remove explicit pci ids from virtio_pci.c
Date: Mon, 21 Jan 2008 11:30:50 +1100 [thread overview]
Message-ID: <200801211130.51401.rusty@rustcorp.com.au> (raw)
Qumranet let us use their PCI vendor ID, with device ids >= 0x1000.
We can specify that we accept all of them in the device ID table, and
then return -ENODEV in the probe routine.
modprobe will load all the modules which match a given alias so we
might be loaded when we're not needed, but that's the worst that can
happen.
Signed-off-by: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
---
drivers/virtio/virtio_pci.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff -r 4edff5e24614 drivers/virtio/virtio_pci.c
--- a/drivers/virtio/virtio_pci.c Sun Jan 20 21:01:32 2008 +1100
+++ b/drivers/virtio/virtio_pci.c Mon Jan 21 11:05:19 2008 +1100
@@ -62,10 +62,9 @@ struct virtio_pci_vq_info
struct list_head node;
};
-/* We have to enumerate here all virtio PCI devices. */
+/* Qumranet donated their vendor ID and devices >= 0x1000 */
static struct pci_device_id virtio_pci_id_table[] = {
- { 0x1af4, 0x1000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* virtio net */
- { 0x1af4, 0x1001, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* virtio blk */
+ { 0x1af4, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ 0 },
};
@@ -303,6 +302,10 @@ static int __devinit virtio_pci_probe(st
struct virtio_pci_device *vp_dev;
int err;
+ /* We only own device ids >= 0x1000 */
+ if (pci_dev->device < 0x1000)
+ return -ENODEV;
+
/* allocate our structure and fill it out */
vp_dev = kzalloc(sizeof(struct virtio_pci_device), GFP_KERNEL);
if (vp_dev == NULL)
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next reply other threads:[~2008-01-21 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 0:30 Rusty Russell [this message]
[not found] ` <200801211130.51401.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2008-01-21 4:34 ` [PATCH] virtio: remove explicit pci ids from virtio_pci.c Anthony Liguori
[not found] ` <479420D2.7050902-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-21 9:12 ` Avi Kivity
[not found] ` <4794620E.7010900-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-21 11:22 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801211130.51401.rusty@rustcorp.com.au \
--to=rusty-8n+1lvoiyb80n/f98k4iww@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox