From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Arcangeli Subject: [PATCH] kvm-userland mm count skew Date: Mon, 21 Jan 2008 13:44:55 +0100 Message-ID: <20080121124455.GI6970@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org I still can't see how it could be possibly make a difference for the mm_count if the kvm module is compiled inside the kernel or as an external module, the reference counting there hasn't changed since ages. The mmdrop fires only in the first overflow so even if I'm right it probably wasn't much destabilizing to go negative given it happened at mm destruction time. Signed-off-by: Andrea Arcangeli diff --git a/kernel/hack-module.awk b/kernel/hack-module.awk index 5187c96..884bc50 100644 --- a/kernel/hack-module.awk +++ b/kernel/hack-module.awk @@ -33,8 +33,6 @@ vmx_load_host_state = 0 } -/atomic_inc\(&kvm->mm->mm_count\);/ { $0 = "//" $0 } - /^\t\.fault = / { fcn = gensub(/,/, "", "g", $3) $0 = "\t.VMA_OPS_FAULT(fault) = VMA_OPS_FAULT_FUNC(" fcn ")," ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/