public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] janitor: revert accidental type change
Date: Mon, 21 Jan 2008 07:20:13 -0600	[thread overview]
Message-ID: <20080121132013.GA28468@tapir> (raw)
In-Reply-To: <47948ECC.9000404-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>

On Mon, Jan 21, 2008 at 01:23:40PM +0100, Jan Kiszka wrote:
> While trying to reduce the warning noise (to identify warnings of
> homebrewed patches), I also came across this bogus but fortunately
> harmless type change in bdrv_commit. Fix below

the same fix was proposed before in :

  http://www.mail-archive.com/kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org/msg11246.html

but as you can see in that thread, a more complete change will be needed
to cover for alignment issues when using direct IO (cache=off)

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-21 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 12:23 [PATCH] janitor: revert accidental type change Jan Kiszka
     [not found] ` <47948ECC.9000404-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2008-01-21 13:01   ` Laurent Vivier
2008-01-21 13:20   ` Carlo Marcelo Arenas Belon [this message]
2008-01-22 13:33   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080121132013.GA28468@tapir \
    --to=carenas-kledwsohozojb6fo7hg9ng@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox