From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Marcelo Arenas Belon Subject: Re: [PATCH] janitor: revert accidental type change Date: Mon, 21 Jan 2008 07:20:13 -0600 Message-ID: <20080121132013.GA28468@tapir> References: <47948ECC.9000404@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: Jan Kiszka Return-path: Content-Disposition: inline In-Reply-To: <47948ECC.9000404-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Mon, Jan 21, 2008 at 01:23:40PM +0100, Jan Kiszka wrote: > While trying to reduce the warning noise (to identify warnings of > homebrewed patches), I also came across this bogus but fortunately > harmless type change in bdrv_commit. Fix below the same fix was proposed before in : http://www.mail-archive.com/kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org/msg11246.html but as you can see in that thread, a more complete change will be needed to cover for alignment issues when using direct IO (cache=off) Carlo ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/