Re: [RFC][PATCH 1/2] KVM: In-kernel PIT model

Jan Kiszka
2008-01-21T10:22:10Z

Avi Kivity wrote:
> Jan Kiszka wrote:
>> The PIT may not be limited to x86 platforms. So I would propose to make
>> the setup more generic and flexible. And I would move the code out of
>> arch/x86, just the speaker support should remain there.
>>
>> I'm currently struggling with emulating a proprietary platform that has
>> (among other specialties...) a different PIT base frequency, and I
>> already had to patch user space qemu for customizable frequencies. Maybe
>> this kernel extension is a good chance to generalize the PIT setup, and
>> I would be happy to contribute to this if there is a consensus.
>>
>
> Certainly an ioctl() to configure the PIT can be added. I think that we
> can leave that to a later patch though.

I would rather stuff these parameters into KVM_CREATE_PIT right from the
beginning than later breaking the kernel/user ABI or adding a clumsy
KVM_CREATE_PIT_SPECIAL_EXTENDED_VERSION. :->

Jan

--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux