public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Yang, Sheng" <sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)
Date: Fri, 25 Jan 2008 15:01:54 +0800	[thread overview]
Message-ID: <200801251501.54884.sheng.yang@intel.com> (raw)
In-Reply-To: <4799873F.1070503-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

On Friday 25 January 2008 14:52:47 Avi Kivity wrote:
> Yang, Sheng wrote:
> > Here is the updated patch:
>
> Applied, thanks.
>
> > @@ -1714,6 +1788,8 @@ static int vmx_vcpu_reset(struct kvm_vcpu *vcpu)
> >  	vmx_fpu_activate(&vmx->vcpu);
> >  	update_exception_bitmap(&vmx->vcpu);
> >
> > +	vpid_sync_all();
> > +
> >  	return 0;
>
> This causes the new instruction to be executed unconditionally, which
> would #UD on older processors, no?  I replaced it with
> vpid_sync_vcpu_all() which seems sufficient, or do I miss something?

I think it's OK for there is a judgment in __invvpid() to see if machine has 
the ability(also if it is allowed to using VPID). :)

Thanks!

-- 
Thanks
Yang, Sheng

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-25  7:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24  6:26 [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID) Yang, Sheng
     [not found] ` <200801241426.55928.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2008-01-24 11:15   ` Aurelien Jarno
     [not found]     ` <4798736D.8000002-rXXEIb44qovR7s880joybQ@public.gmane.org>
2008-01-25  1:47       ` Yang, Sheng
2008-01-24 11:50   ` Avi Kivity
     [not found]     ` <47987B7C.1080509-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-25  4:12       ` Yang, Sheng
     [not found]         ` <200801251212.29031.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2008-01-25  6:52           ` Avi Kivity
     [not found]             ` <4799873F.1070503-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-25  7:01               ` Yang, Sheng [this message]
     [not found]                 ` <200801251501.54884.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2008-01-25  7:03                   ` Avi Kivity
     [not found]                     ` <479989C0.90307-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-25  8:34                       ` Yang, Sheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801251501.54884.sheng.yang@intel.com \
    --to=sheng.yang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox