Re: [RFC] nmi watchdog in kvm

Balaji Rao
2008-01-30T14:22:57Z

On Wednesday 30 January 2008 04:13:58 pm Avi Kivity wrote:
> > @@ -790,6 +795,18 @@ static int apic_mmio_range(struct kvm_io_device
> > *this, gpa_t addr) return ret;
> > }
> >
> > +static int nmi_notify(struct notifier_block *self,unsigned long val,
> > void *data) { +
> > + struct kvm *kvm;
> > + kvm = list_entry(vm_list.next, struct kvm, vm_list);
> > + kvm_x86_ops->inject_nmi(kvm->vcpus[0]);
> > + return NOTIFY_STOP;
> > +}
>
> You're not guaranteed to be in vcpu context here, that's what's causing
> the vmwrite errors.
>
I intended to do this here. Looks like its not the right way to check for
presence in vcpu context. How do i do it ? please explain.

+static void vmx_inject_nmi(struct kvm_vcpu *vcpu) {
+
+       struct vcpu_vmx * vmx = to_vmx(vcpu);
+               if (vmx->launched)
+               vmcs_write32(VM_ENTRY_INTR_INFO_FIELD,
+                       2 | INTR_TYPE_NMI | INTR_INFO_VALID_MASK);
+}

regards,
balaji rao