[PATCH]

["S.Çağlar Onur" <caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org>]

Hi;

This patch (rediffed againg kvm-60) from Tavis Ormandy <taviso@google.com> fixes an infinite
loop in the emulated SB16 device (See http://taviso.decsystem.org/virtsec.pdf for more details.)

I'm not sure why qemu upstream not merged these but Xen already did.

[1] http://xenbits.xensource.com/xen-3.1-testing.hg?rev/4b22d472bda6

diff -ur kvm-60.orig/qemu/hw/sb16.c kvm-60/qemu/hw/sb16.c
--- kvm-60.orig/qemu/hw/sb16.c	2008-01-20 14:35:04.000000000 +0200
+++ kvm-60/qemu/hw/sb16.c	2008-01-29 01:46:20.000000000 +0200
@@ -1240,8 +1240,10 @@
             s->block_size);
 #endif
 
-    while (s->left_till_irq <= 0) {
-        s->left_till_irq = s->block_size + s->left_till_irq;
+    if (s->block_size) {
+        while (s->left_till_irq <= 0) {
+            s->left_till_irq = s->block_size + s->left_till_irq;
+        }
     }
 
     return dma_pos;

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel