[PATCH]

[PATCH]

[S.Çağlar Onur]

Hi;

This patch (rediffed againg kvm-60) from Tavis Ormandy <taviso@google.com> fixes an infinite
loop in the emulated SB16 device (See http://taviso.decsystem.org/virtsec.pdf for more details.)

I'm not sure why qemu upstream not merged these but Xen already did.

[1] http://xenbits.xensource.com/xen-3.1-testing.hg?rev/4b22d472bda6

diff -ur kvm-60.orig/qemu/hw/sb16.c kvm-60/qemu/hw/sb16.c
--- kvm-60.orig/qemu/hw/sb16.c	2008-01-20 14:35:04.000000000 +0200
+++ kvm-60/qemu/hw/sb16.c	2008-01-29 01:46:20.000000000 +0200
@@ -1240,8 +1240,10 @@
             s->block_size);
 #endif
 
-    while (s->left_till_irq <= 0) {
-        s->left_till_irq = s->block_size + s->left_till_irq;
+    if (s->block_size) {
+        while (s->left_till_irq <= 0) {
+            s->left_till_irq = s->block_size + s->left_till_irq;
+        }
     }
 
     return dma_pos;

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [PATCH]

[Izik Eidus]

S.Çağlar Onur wrote:
> Hi;
>
> This patch (rediffed againg kvm-60) from Tavis Ormandy <taviso@google.com> fixes an infinite
> loop in the emulated SB16 device (See http://taviso.decsystem.org/virtsec.pdf for more details.)
>
> I'm not sure why qemu upstream not merged these but Xen already did.
>
> [1] http://xenbits.xensource.com/xen-3.1-testing.hg?rev/4b22d472bda6
>
> diff -ur kvm-60.orig/qemu/hw/sb16.c kvm-60/qemu/hw/sb16.c
> --- kvm-60.orig/qemu/hw/sb16.c	2008-01-20 14:35:04.000000000 +0200
> +++ kvm-60/qemu/hw/sb16.c	2008-01-29 01:46:20.000000000 +0200
> @@ -1240,8 +1240,10 @@
>              s->block_size);
>  #endif
>  
> -    while (s->left_till_irq <= 0) {
> -        s->left_till_irq = s->block_size + s->left_till_irq;
> +    if (s->block_size) {
> +        while (s->left_till_irq <= 0) {
> +            s->left_till_irq = s->block_size + s->left_till_irq;
> +        }
>      }
>  
>      return dma_pos;
>
> Cheers
>   
we better wait for qemu to merge it and then when we will merge with 
qemu cvs we will have it

thanks

-- 
woof.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [PATCH]

[S.Çağlar Onur]

[-- Attachment #1.1: Type: text/plain, Size: 653 bytes --]

Hi;

29 Oca 2008 Sal tarihinde, Izik Eidus şunları yazmıştı: 
> we better wait for qemu to merge it and then when we will merge with 
> qemu cvs we will have it

OK fair enough, seems they submitted to qemu-devel yesterday by Aurelien Jarno [1] [2], although xen merged these 3 months ago :(

[1] http://lists.gnu.org/archive/html/qemu-devel/2008-01/msg00704.html
[2] http://lists.gnu.org/archive/html/qemu-devel/2008-01/msg00705.html

Cheers
-- 
S.Çağlar Onur <caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel