public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
To: Christoph Lameter <clameter-sJ/iWh9BUns@public.gmane.org>
Cc: Nick Piggin <npiggin-l3A5Bk7waGM@public.gmane.org>,
	Andrea Arcangeli <andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
	Peter Zijlstra
	<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	Benjamin Herrenschmidt
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	Jack Steiner <steiner-sJ/iWh9BUns@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
	kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org,
	Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>,
	Hugh Dickins <hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [patch 1/6] mmu_notifier: Core code
Date: Wed, 30 Jan 2008 16:20:35 -0600	[thread overview]
Message-ID: <20080130222035.GX26420@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0801301116510.27491-RYO/mD75kfhx2SFC9UQUAuF7EQX82lMiAL8bYrjMMd8@public.gmane.org>

On Wed, Jan 30, 2008 at 11:19:28AM -0800, Christoph Lameter wrote:
> On Wed, 30 Jan 2008, Jack Steiner wrote:
> 
> > Moving to a different lock solves the problem.
> 
> Well it gets us back to the issue why we removed the lock. As Robin said 
> before: If its global then we can have a huge number of tasks contending 
> for the lock on startup of a process with a large number of ranks. The 
> reason to go to mmap_sem was that it was placed in the mm_struct and so we 
> would just have a couple of contentions per mm_struct.
> 
> I'll be looking for some other way to do this.

I think Andrea's original concept of the lock in the mmu_notifier_head
structure was the best.  I agree with him that it should be a spinlock
instead of the rw_lock.

Thanks,
Robin

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-30 22:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30  2:29 [patch 0/6] [RFC] MMU Notifiers V3 Christoph Lameter
2008-01-30  2:29 ` [patch 1/6] mmu_notifier: Core code Christoph Lameter
     [not found]   ` <20080130022944.236370194-sJ/iWh9BUns@public.gmane.org>
2008-01-30 15:37     ` Andrea Arcangeli
     [not found]       ` <20080130153749.GN7233-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org>
2008-01-30 15:53         ` Jack Steiner
     [not found]           ` <20080130155306.GA13746-sJ/iWh9BUns@public.gmane.org>
2008-01-30 16:38             ` Andrea Arcangeli
2008-01-30 19:19             ` Christoph Lameter
     [not found]               ` <Pine.LNX.4.64.0801301116510.27491-RYO/mD75kfhx2SFC9UQUAuF7EQX82lMiAL8bYrjMMd8@public.gmane.org>
2008-01-30 22:20                 ` Robin Holt [this message]
     [not found]                   ` <20080130222035.GX26420-sJ/iWh9BUns@public.gmane.org>
2008-01-30 23:38                     ` Andrea Arcangeli
2008-01-30 23:55                       ` Christoph Lameter
     [not found]                         ` <Pine.LNX.4.64.0801301552210.1722-RYO/mD75kfhx2SFC9UQUAuF7EQX82lMiAL8bYrjMMd8@public.gmane.org>
2008-01-31  0:12                           ` Andrea Arcangeli
     [not found]                             ` <20080131001258.GD7185-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org>
2008-01-31  1:27                               ` Christoph Lameter
2008-01-30 17:10       ` Peter Zijlstra
2008-01-30 19:28         ` Christoph Lameter
2008-01-30 18:02     ` Robin Holt
     [not found]       ` <20080130180207.GU26420-sJ/iWh9BUns@public.gmane.org>
2008-01-30 19:08         ` Christoph Lameter
2008-01-30 19:14         ` Christoph Lameter
2008-01-30  2:29 ` [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges Christoph Lameter
2008-01-30  2:29 ` [patch 3/6] mmu_notifier: invalidate_page callbacks for subsystems with rmap Christoph Lameter
     [not found]   ` <20080130022944.699753910-sJ/iWh9BUns@public.gmane.org>
2008-01-30 18:03     ` Robin Holt
2008-01-30  2:29 ` [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps Christoph Lameter
2008-01-30  2:29 ` [patch 5/6] mmu_notifier: Callbacks for xip_filemap.c Christoph Lameter
2008-01-30  2:29 ` [patch 6/6] mmu_notifier: Add invalidate_all() Christoph Lameter
  -- strict thread matches above, loose matches on Subject: below --
2008-02-15  6:48 [ofa-general] [patch 0/6] MMU Notifiers V7 Christoph Lameter
2008-02-15  6:49 ` [patch 1/6] mmu_notifier: Core code Christoph Lameter
2008-02-16  3:37   ` [ofa-general] " Andrew Morton
2008-02-16  8:45     ` Avi Kivity
2008-02-16  8:56       ` [ofa-general] " Andrew Morton
2008-02-16  9:21         ` Avi Kivity
2008-02-16 19:21     ` [ofa-general] " Christoph Lameter
2008-02-17  3:01       ` Andrea Arcangeli
2008-02-17 12:24         ` Robin Holt
2008-02-17  5:04     ` Doug Maxey
2008-02-08 22:06 [patch 0/6] MMU Notifiers V6 Christoph Lameter
2008-02-08 22:06 ` [patch 1/6] mmu_notifier: Core code Christoph Lameter
2008-01-28 20:28 [patch 0/6] [RFC] MMU Notifiers V2 Christoph Lameter
2008-01-28 20:28 ` [patch 1/6] mmu_notifier: Core code Christoph Lameter
     [not found]   ` <20080128202923.609249585-sJ/iWh9BUns@public.gmane.org>
2008-01-28 22:06     ` Christoph Lameter
2008-01-29  0:05     ` Robin Holt
     [not found]       ` <20080129000534.GT3058-sJ/iWh9BUns@public.gmane.org>
2008-01-29  1:19         ` Christoph Lameter
2008-01-29 13:59     ` Andrea Arcangeli
     [not found]       ` <20080129135914.GF7233-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org>
2008-01-29 14:34         ` Andrea Arcangeli
2008-01-29 19:49         ` Christoph Lameter
     [not found]           ` <Pine.LNX.4.64.0801291148080.24807-RYO/mD75kfhx2SFC9UQUAuF7EQX82lMiAL8bYrjMMd8@public.gmane.org>
2008-01-29 20:41             ` Avi Kivity
2008-01-29 16:07     ` Robin Holt
2008-02-05 18:05     ` Andy Whitcroft
2008-02-05 18:17       ` Peter Zijlstra
     [not found]       ` <20080205180557.GC29502-26w3C0LaAnFg9hUCZPvPmw@public.gmane.org>
2008-02-05 18:19         ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080130222035.GX26420@sgi.com \
    --to=holt-sj/iwh9buns@public.gmane.org \
    --cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
    --cc=andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=clameter-sJ/iWh9BUns@public.gmane.org \
    --cc=daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org \
    --cc=hugh-DTz5qymZ9yRBDgjK7y7TUQ@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=npiggin-l3A5Bk7waGM@public.gmane.org \
    --cc=steiner-sJ/iWh9BUns@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox