From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Steiner Subject: Re: [patch 1/3] mmu_notifier: Core code Date: Thu, 31 Jan 2008 20:37:00 -0600 Message-ID: <20080201023659.GA30057@sgi.com> References: <20080131045750.855008281@sgi.com> <20080131045812.553249048@sgi.com> <20080201015611.GA15893@sgi.com> <20080201022444.GA26420@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Peter Zijlstra , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Avi Kivity , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org, Christoph Lameter To: Robin Holt Return-path: Content-Disposition: inline In-Reply-To: <20080201022444.GA26420-sJ/iWh9BUns@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, Jan 31, 2008 at 08:24:44PM -0600, Robin Holt wrote: > On Thu, Jan 31, 2008 at 07:56:12PM -0600, Jack Steiner wrote: > > > @@ -2033,6 +2034,7 @@ void exit_mmap(struct mm_struct *mm) > > > unsigned long end; > > > > > > /* mm's last user has gone, and its about to be pulled down */ > > > + mmu_notifier(invalidate_all, mm, 0); > > > arch_exit_mmap(mm); > > > > > > > The name of the "invalidate_all" callout is not very descriptive. > > Why not use "exit_mmap". That matches the function name, the arch callout > > and better describes what is happening. > > This got removed in a later patch. We now only do the release. Found it, thanks. Christoph, is it time to post a new series of patches? I've got as many fixup patches as I have patches in the original posting. -- jack ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/