From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Holt Subject: Re: [patch 2/4] mmu_notifier: Callbacks to invalidate address ranges Date: Fri, 1 Feb 2008 18:38:52 -0600 Message-ID: <20080202003852.GB17211@sgi.com> References: <20080201050439.009441434@sgi.com> <20080201050623.344041545@sgi.com> <20080201220952.GA3875@sgi.com> <20080201233528.GE12099@sgi.com> <20080202002145.GA17211@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Peter Zijlstra , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, steiner-sJ/iWh9BUns@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Avi Kivity , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org, Robin Holt To: Christoph Lameter Return-path: Content-Disposition: inline In-Reply-To: <20080202002145.GA17211-sJ/iWh9BUns@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Fri, Feb 01, 2008 at 06:21:45PM -0600, Robin Holt wrote: > On Fri, Feb 01, 2008 at 04:05:08PM -0800, Christoph Lameter wrote: > > Are you saying that you get the callback when transitioning from a read > > only to a read write pte on the *same* page? > > I believe that is what we saw. We have not put in any more debug > information yet. I will try to squeze it in this weekend. Otherwise, > I will probably have to wait until early Monday. I hate it when I am confused. I misunderstood what Dean had been saying. After I looked at his test case and remembering his screen at the time we were discussing, I am nearly positive that both the parent and child were still running (no exec, no exit). We would therefore have two refs on the page and, yes, be changing the pte which would warrant the callout. Now I really need to think this through more. Sounds like a good thing for Monday. Thanks, Robin ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/