From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] make KVM selectable again
Date: Sat, 9 Feb 2008 22:24:01 +0100
Message-ID: <20080209212401.GA13888@elte.hu>
References: <1202590755.14165.11.camel@nimitz.home.sr71.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	Sam Ravnborg <sam@ravnborg.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Avi Kivity <avi@argo.co.il>
To: Dave Hansen <haveblue@us.ibm.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
Content-Disposition: inline
In-Reply-To: <1202590755.14165.11.camel@nimitz.home.sr71.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org


* Dave Hansen <haveblue@us.ibm.com> wrote:

>  config HAVE_SETUP_PER_CPU_AREA
>  	def_bool X86_64
>  
> -select HAVE_KVM
> +config HAVE_KVM
> +	def_bool y

i think it might be better to just move the select to after the "config 
X86" option. (this is a legitimate use of select) Sam, do you concur?

(but, your current fix should go in ASAP, so no objections from me.)

	Ingo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/