From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Avi Kivity <avi@argo.co.il>
Subject: Re: [PATCH] make KVM selectable again
Date: Sun, 10 Feb 2008 11:49:41 +0100 [thread overview]
Message-ID: <20080210104941.GC10790@uranus.ravnborg.org> (raw)
In-Reply-To: <20080209212401.GA13888@elte.hu>
On Sat, Feb 09, 2008 at 10:24:01PM +0100, Ingo Molnar wrote:
>
> * Dave Hansen <haveblue@us.ibm.com> wrote:
>
> > config HAVE_SETUP_PER_CPU_AREA
> > def_bool X86_64
> >
> > -select HAVE_KVM
> > +config HAVE_KVM
> > + def_bool y
>
> i think it might be better to just move the select to after the "config
> X86" option. (this is a legitimate use of select) Sam, do you concur?
Correct.
We should see it used like this:
config X86
select HAVE_KVM
Sam
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-10 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 20:59 [PATCH] make KVM selectable again Dave Hansen
2008-02-09 21:24 ` Ingo Molnar
2008-02-10 10:49 ` Sam Ravnborg [this message]
2008-02-10 10:50 ` Sam Ravnborg
2008-02-10 11:38 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210104941.GC10790@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=avi@argo.co.il \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox