From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to
	enable > 2G support (v2)
Date: Sun, 10 Feb 2008 14:12:26 +0000
Message-ID: <200802101412.27850.paul@codesourcery.com>
References: <1201903921-1125-1-git-send-email-aliguori@us.ibm.com>
	<1202114748.30861.6.camel@localhost.localdomain>
	<47AED66F.3050201@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <47AED66F.3050201@qumranet.com>
Content-Disposition: inline
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

> > as far as i remember it was used to address something with
> > cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE
> > or ~TARGET_PAGE_SIZE,
> >
> > the fact is that i dont know if it ever fixed anything
>
> It fixes TARGET_PAGE_MASK, defined one line downscreen. 

That doesn't really answer the question. What was wrong with the original 
definition?

Paul

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/