From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <marcelo@kvack.org>
Subject: Re: [PATCH 4/8] KVM: MMU: hypercall based pte updates
	and TLB flushes
Date: Mon, 3 Mar 2008 11:43:35 -0300
Message-ID: <20080303144335.GA3281@dmt>
References: <1204475481-16583-5-git-send-email-avi@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net
To: Avi Kivity <avi@qumranet.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
Content-Disposition: inline
In-Reply-To: <1204475481-16583-5-git-send-email-avi@qumranet.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Hi Avi,

Looks nice.

On Sun, Mar 02, 2008 at 06:31:17PM +0200, Avi Kivity wrote:
> +int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes,
> +		  gpa_t addr, unsigned long *ret)
> +{
> +	int r;
> +	struct kvm_pv_mmu_op_buffer buffer;

Perhaps this structure is a little large to be on stack.

> +	down_read(&current->mm->mmap_sem);
> +	down_read(&vcpu->kvm->slots_lock);

The order should be slots_locks then mmap_sem. Need some comment in the
code.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/