Re: [PATCH 1/6] KVM: In kernel pit model

[Ingo Molnar <mingo@elte.hu>]

* Yang, Sheng <sheng.yang@intel.com> wrote:

> +	/* Though spec said the state of 8254 is undefined after power-up,
> +	 * seems some tricky OS like Windows XP depends on IRQ0 interrupt
> +	 * when booting up.
> +	 * So here setting initialize rate for it, and not a specific number */

another silly style nit, the canonical comment style is:

> +	/*
> +	 * Though spec said the state of 8254 is undefined after power-up,
> +	 * seems some tricky OS like Windows XP depends on IRQ0 interrupt
> +	 * when booting up.
> +	 * So here setting initialize rate for it, and not a specific number
> +	 */

we are standardizing on that in other areas of arch/x86 and KVM uses 
that too.

but your patch looks good otherwise :)

/me goes back into lurker mode

	Ingo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/