From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 1/6] KVM: In kernel pit model Date: Thu, 6 Mar 2008 10:14:34 +0100 Message-ID: <20080306091434.GA12919@elte.hu> References: <200803041822.44757.sheng.yang@intel.com> <20080305091529.GA25357@elte.hu> <200803051935.40229.sheng.yang@intel.com> <200803061556.18427.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Avi Kivity To: "Yang, Sheng" Return-path: Content-Disposition: inline In-Reply-To: <200803061556.18427.sheng.yang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org * Yang, Sheng wrote: > + /* Though spec said the state of 8254 is undefined after power-up, > + * seems some tricky OS like Windows XP depends on IRQ0 interrupt > + * when booting up. > + * So here setting initialize rate for it, and not a specific number */ another silly style nit, the canonical comment style is: > + /* > + * Though spec said the state of 8254 is undefined after power-up, > + * seems some tricky OS like Windows XP depends on IRQ0 interrupt > + * when booting up. > + * So here setting initialize rate for it, and not a specific number > + */ we are standardizing on that in other areas of arch/x86 and KVM uses that too. but your patch looks good otherwise :) /me goes back into lurker mode Ingo ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/