public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Balaji Rao <balajirrao@gmail.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Mark kobjects as unitialized
Date: Thu, 6 Mar 2008 09:05:14 -0800	[thread overview]
Message-ID: <20080306170514.GA13839@suse.de> (raw)
In-Reply-To: <200803062223.18857.balajirrao@gmail.com>

On Thu, Mar 06, 2008 at 10:23:18PM +0530, Balaji Rao wrote:
> Hi greg,
> 
> When I remove only the kvm-intel module without removing the kvm
> module itself, I get an error saying that a kobject is trying to be
> reinitialized. Its because of the fact that kvm reuses a kobject in
> kvm_init when calling sysdev_register.

Where exactly in the code does that happen?  kobjects should not be
"reused" as that implies that they are static, and not dynamically
allocated, right?

Which kobject is this?

Ugh, is this the sys_device stuff?  I hate that code...

> This patch fixes kobject_cleanup by marking the kobject as
> uninitialized when we cleanup to allow kobjects to be reused.

The patch seems correct, but I would like to verify which kobject is
being reused here first.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-03-06 17:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 16:53 [PATCH] Mark kobjects as unitialized Balaji Rao
2008-03-06 17:05 ` Greg KH [this message]
2008-03-06 17:50   ` Balaji Rao
2008-03-06 18:05     ` Greg KH
2008-03-07  8:56       ` Avi Kivity
2008-03-08 22:07       ` Balaji Rao
2008-03-09  5:06         ` Greg KH
2008-03-09  6:16           ` Greg KH
2008-03-09  6:17           ` Balaji Rao
2008-03-09  6:33         ` Greg KH
2008-03-09  6:36           ` Balaji Rao
2008-03-09  7:03             ` Greg KH
2008-03-09  7:21               ` Balaji Rao
2008-03-09 10:49                 ` Mikael Pettersson
2008-03-10 17:20                   ` Greg KH
2008-03-10 15:52                 ` Greg KH
2008-03-10 16:05                   ` Balaji Rao
2008-03-10 17:20                     ` Greg KH
2008-03-06 18:34 ` patch kobjects-mark-cleaned-up-kobjects-as-unitialized.patch added to gregkh-2.6 tree gregkh
2008-03-09  4:58 ` patch patches/driver-core/kobjects-mark-cleaned-up-kobjects-as-unitialized.patch " gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080306170514.GA13839@suse.de \
    --to=gregkh@suse.de \
    --cc=balajirrao@gmail.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox