From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Sheng" Subject: Re: [PATCH 1/6] KVM: In kernel pit model Date: Thu, 6 Mar 2008 17:25:53 +0800 Message-ID: <200803061725.53619.sheng.yang@intel.com> References: <200803041822.44757.sheng.yang@intel.com> <200803061556.18427.sheng.yang@intel.com> <20080306091434.GA12919@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Avi Kivity To: Ingo Molnar Return-path: In-Reply-To: <20080306091434.GA12919@elte.hu> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org On Thursday 06 March 2008 17:14:34 Ingo Molnar wrote: > * Yang, Sheng wrote: > > + /* Though spec said the state of 8254 is undefined after power-up, > > + * seems some tricky OS like Windows XP depends on IRQ0 interrupt > > + * when booting up. > > + * So here setting initialize rate for it, and not a specific number */ > > another silly style nit, the canonical comment style is: > > + /* > > + * Though spec said the state of 8254 is undefined after power-up, > > + * seems some tricky OS like Windows XP depends on IRQ0 interrupt > > + * when booting up. > > + * So here setting initialize rate for it, and not a specific number > > + */ > > we are standardizing on that in other areas of arch/x86 and KVM uses > that too. ... Seems I still can't fully depend on script/checkpatch.pl to correct my coding style error... > but your patch looks good otherwise :) > > /me goes back into lurker mode > > Ingo Thanks for review! :) Yang, Sheng ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/