public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: headersinstall of kvm.h does not work
Date: Fri, 7 Mar 2008 13:26:06 +0100	[thread overview]
Message-ID: <200803071326.06682.borntraeger@de.ibm.com> (raw)

Hello Avi,

in commit fb56dbb31c4738a3918db81fd24da732ce3b4ae6 you changed 
include/linux/Kbuild:
----snip----
KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h>
includes, not existing.  Rather than add a zillion <asm/kvm.h>s, export 
kvm.h only if the arch actually supports it.
[...]
 unifdef-y += keyboard.h
-unifdef-y += kvm.h
+unifdef-$(CONFIG_HAVE_KVM) += kvm.h
 unifdef-y += llc.h
 unifdef-y += loop.h
----snip------

This patch does not work. Kbuild (scripts/Makefile.headersinst) does not 
check the config file, so kvm.h is never installed.

Sam is there an easy way to allow constructs like "unifdef-$(CONFIG_FOO)"?

Thanks

Christian

             reply	other threads:[~2008-03-07 12:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07 12:26 Christian Borntraeger [this message]
2008-03-07 12:57 ` headersinstall of kvm.h does not work Avi Kivity
2008-03-07 13:57   ` Christian Borntraeger
2008-03-07 16:08     ` Avi Kivity
2008-03-07 23:43 ` David Woodhouse
2008-03-10  8:13   ` [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install Christian Borntraeger
2008-03-10 11:23     ` Arnd Bergmann
2008-03-10 13:11   ` Christian Borntraeger
2008-03-11  6:20     ` Andrew Morton
2008-03-11  6:42       ` David Woodhouse
     [not found]         ` <1205217745.2592.86.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2008-03-11  7:10           ` Christian Borntraeger
2008-03-11  9:33             ` Andreas Schwab
     [not found]               ` <je7ig9hag4.fsf-+JVCjXrnBTholqkO4TVVkw@public.gmane.org>
2008-03-11 10:02                 ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803071326.06682.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox