From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: [patch 2/3] QEMU/KVM: virtio register pow2 memory regions Date: Mon, 17 Mar 2008 17:20:15 -0300 Message-ID: <20080317202125.391559627@localhost.localdomain> References: <20080317202013.949027343@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Marcelo Tosatti To: Avi Kivity Return-path: Content-Disposition: inline; filename=fix-virtio List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Otherwise the PCI size for such regions will be calculated erroneously. Signed-off-by: Marcelo Tosatti Cc: Anthony Liguori Index: kvm-userspace.hotplug3/qemu/hw/virtio.c =================================================================== --- kvm-userspace.hotplug3.orig/qemu/hw/virtio.c +++ kvm-userspace.hotplug3/qemu/hw/virtio.c @@ -404,6 +404,7 @@ VirtIODevice *virtio_init_pci(PCIBus *bu VirtIODevice *vdev; PCIDevice *pci_dev; uint8_t *config; + uint32_t size; pci_dev = pci_register_device(bus, name, struct_size, -1, NULL, NULL); @@ -441,7 +442,11 @@ VirtIODevice *virtio_init_pci(PCIBus *bu else vdev->config = NULL; - pci_register_io_region(pci_dev, 0, 20 + config_size, PCI_ADDRESS_SPACE_IO, + size = 20 + config_size; + if (size & (size-1)) + size = 1 << fls(size); + + pci_register_io_region(pci_dev, 0, size, PCI_ADDRESS_SPACE_IO, virtio_map); qemu_register_reset(virtio_reset, vdev); -- ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/