Re: [kvm-devel] [RFC/PATCH 06/15] kvm-s390: sie intercept handling

Avi Kivity
2008-03-21T10:53:25Z

Carsten Otte wrote:
>
> /* for KVM_RUN, returned by mmap(vcpu_fd, offset=0) */
> struct kvm_run {
> @@ -138,6 +139,14 @@ struct kvm_run {
> __u32 is_write;
> __u32 pad;
> } tpr_access;
> + /* KVM_EXIT_S390_SIEIC */
> + struct {
> + __u8 icptcode;
> + __u64 mask; /* psw upper half */
> + __u64 addr; /* psw lower half */
> + __u16 ipa;
> + __u32 ipb;
> + } s390_sieic;
> /* Fix the size of the union. */
> char padding[256];
> };
>
>

Do you support 32-bit userspace on 64-bit kernel? If so, this is likely
badly aligned.

--
Any sufficiently difficult bug is indistinguishable from a feature.