Re: [RFC/PATCH 15/15] guest: virtio device support, and kvm hypercalls

Rusty Russell
2008-03-21T23:30:48Z

On Friday 21 March 2008 19:15:47 Christian Borntraeger wrote:
> Am Freitag, 21. März 2008 schrieb Rusty Russell:
> > Hmm, panic on device_register fail, but -ENOMEM on add_shared_memory
> > fail? My theory was that since this is boot time, panic() is the right
> > thing.
>
> Good spot, but I agree with Carsten. Drivers should not panic. I have
> module load/unload capability on my long term todo list, but I can change
> the panic now.

Yep, that makes sense. For lguest, we panic: it's always at boot time so if
it fails we should die early to make it easier to diagnose (and that makes
sure it happens before we lose our early console).

Cheers,
Rusty.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net