Re: [RFC/PATCH 05/15] KVM_MAX_VCPUS

Carsten Otte
2008-03-21T11:13:16Z

Avi Kivity wrote:
> Carsten Otte wrote:
>> Hollis Blanchard wrote:
>>
>>> On Thu, 2008-03-20 at 17:24 +0100, Carsten Otte wrote:
>>>
>>>> Index: kvm/include/linux/kvm_host.h
>>>> ===================================================================
>>>> --- kvm.orig/include/linux/kvm_host.h
>>>> +++ kvm/include/linux/kvm_host.h
>>>> @@ -24,7 +24,11 @@
>>>>
>>>> #include <asm/kvm_host.h>
>>>>
>>>> +#ifdef CONFIG_S390
>>>> +#define KVM_MAX_VCPUS 64
>>>> +#else
>>>> #define KVM_MAX_VCPUS 16
>>>> +#endif
>>>> #define KVM_MEMORY_SLOTS 32
>>>> /* memory slots that does not exposed to userspace */
>>>> #define KVM_PRIVATE_MEM_SLOTS 4
>>>>
>>>>
>>> Why don't we just define this in <asm/kvm_host.h> ?
>>>
>> No problem with that, I just wanted to keep impact on common code very
>> low and things like this seperated from the actual port. I have a few
>> things like this that can safely be taken care about later.
>>
>>
>
> Since there were a few other comments, I went ahead and moved those
> #defines to asm-x86.
Great! I will rebase the patch series.