Re: [RFC/PATCH 14/15] guest: detect when running on kvm

Carsten Otte
2008-03-20T20:59:32Z

Christoph Hellwig wrote:
> On Thu, Mar 20, 2008 at 09:37:19PM +0100, Carsten Otte wrote:
>> Christoph Hellwig wrote:
>>> On Thu, Mar 20, 2008 at 05:25:26PM +0100, Carsten Otte wrote:
>>>> @@ -143,6 +143,10 @@ static noinline __init void detect_machi
>>>> /* Running on a P/390 ? */
>>>> if (cpuinfo->cpu_id.machine == 0x7490)
>>>> machine_flags |= 4;
>>>> +
>>>> + /* Running under KVM ? */
>>>> + if (cpuinfo->cpu_id.version == 0xfe)
>>>> + machine_flags |= 64;
>>> Shouldn't these have symbolic names?
>> You mean symbolics for machine_flags? Or symbolics for cpu ids?
>
> Either.
Hmmh. For cpu id's did'nt make sense probably until now that kvm also
uses them. Before, this was the only one place that uses them.

With kvm and 0xfe, this one is sort of temporary one. We intend to
rework this code to use "store system information", which would give
us way more information about the machine and it's hypervisor
topology. Up until my todo list gets to that point, I think we'll have
to cope with a temporary number. We'll aim for making that change
before 2.6.26 gets released.

The machine flags do have symbolic names, defined in
include/asm-s390/setup.h. And yea, they should be used here. Will
change that.