Re: [RFC/PATCH 01/15] preparation: provide hook to enable pgstes in user pagetable

Dave Hansen
2008-03-20T19:13:25Z

On Thu, 2008-03-20 at 10:28 -0700, Jeremy Fitzhardinge wrote:
> Carsten Otte wrote:
> > +struct mm_struct *dup_mm(struct task_struct *tsk);
>
> No prototypes in .c files. Put this in an appropriate header.

Well, and more fundamentally: do we really want dup_mm() able to be
called from other code?

Maybe we need a bit more detailed justification why fork() itself isn't
good enough. It looks to me like they basically need an arch-specific
argument to fork, telling the new process's page tables to take the
fancy new bit.

I'm really curious how this new stuff is going to get used. Are you
basically replacing fork() when creating kvm guests?

-- Dave