From: Rusty Russell <rusty@rustcorp.com.au>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
EHRHARDT@de.ibm.com, arnd@arndb.de, hollisb@us.ibm.com,
kvm-devel@lists.sourceforge.net, heiko.carstens@de.ibm.com,
jeroney@us.ibm.com, Avi Kivity <avi@qumranet.com>,
virtualization@lists.linux-foundation.org,
schwidefsky@de.ibm.com, rvdheij@gmail.com, os@de.ibm.com,
jblunck@suse.de, "Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [RFC/PATCH 15/15] guest: virtio device support, and kvm hypercalls
Date: Sat, 22 Mar 2008 10:30:48 +1100 [thread overview]
Message-ID: <200803221030.49457.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200803210915.48029.borntraeger@de.ibm.com>
On Friday 21 March 2008 19:15:47 Christian Borntraeger wrote:
> Am Freitag, 21. März 2008 schrieb Rusty Russell:
> > Hmm, panic on device_register fail, but -ENOMEM on add_shared_memory
> > fail? My theory was that since this is boot time, panic() is the right
> > thing.
>
> Good spot, but I agree with Carsten. Drivers should not panic. I have
> module load/unload capability on my long term todo list, but I can change
> the panic now.
Yep, that makes sense. For lguest, we panic: it's always at boot time so if
it fails we should die early to make it easier to diagnose (and that makes
sure it happens before we lose our early console).
Cheers,
Rusty.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
next prev parent reply other threads:[~2008-03-21 23:30 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1206028710.6690.21.camel@cotte.boeblingen.de.ibm.com>
2008-03-20 16:24 ` [RFC/PATCH 01/15] preparation: provide hook to enable pgstes in user pagetable Carsten Otte
2008-03-20 17:28 ` Jeremy Fitzhardinge
2008-03-20 19:13 ` Dave Hansen
2008-03-20 20:35 ` Carsten Otte
2008-03-21 18:29 ` [kvm-devel] " Dave Hansen
2008-03-21 19:03 ` Carsten Otte
2008-03-22 17:57 ` Heiko Carstens
2008-03-23 10:15 ` Avi Kivity
2008-03-23 18:23 ` [kvm-devel] " Martin Schwidefsky
2008-03-24 6:57 ` Avi Kivity
2008-03-25 6:08 ` Carsten Otte
2008-03-25 6:12 ` Avi Kivity
2008-03-25 15:37 ` Carsten Otte
2008-03-20 16:24 ` [RFC/PATCH 02/15] preparation: host memory management changes for s390 kvm Carsten Otte
2008-03-20 16:24 ` [RFC/PATCH 03/15] preparation: address of the 64bit extint parm in lowcore Carsten Otte
2008-03-20 16:24 ` [RFC/PATCH 04/15] preparation: split sysinfo defintions for kvm use Carsten Otte
2008-03-20 16:24 ` [RFC/PATCH 05/15] kvm-s390: s390 arch backend for the kvm kernel module Carsten Otte
2008-03-20 16:43 ` [RFC/PATCH 05/15] KVM_MAX_VCPUS Hollis Blanchard
2008-03-20 16:48 ` Carsten Otte
2008-03-21 10:41 ` [kvm-devel] " Avi Kivity
2008-03-21 11:13 ` Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 06/15] kvm-s390: sie intercept handling Carsten Otte
2008-03-21 10:53 ` [kvm-devel] " Avi Kivity
2008-03-21 11:26 ` Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 07/15] kvm-s390: interrupt subsystem, cpu timer, waitpsw Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 08/15] kvm-s390: intercepts for privileged instructions Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 09/15] kvm-s390: interprocessor communication via sigp Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 10/15] kvm-s390: intercepts for diagnose instructions Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 11/15] kvm-s390: add kvm to kconfig on s390 Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 12/15] kvm-s390: API documentation Carsten Otte
2008-03-20 17:22 ` Randy Dunlap
2008-03-21 10:33 ` [kvm-devel] " Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 13/15] kvm-s390: update maintainers Carsten Otte
2008-03-20 16:25 ` [RFC/PATCH 14/15] guest: detect when running on kvm Carsten Otte
2008-03-20 17:16 ` Randy Dunlap
2008-03-20 17:27 ` Carsten Otte
2008-03-20 17:53 ` Christoph Hellwig
2008-03-20 20:37 ` Carsten Otte
2008-03-20 19:41 ` Christoph Hellwig
2008-03-20 20:59 ` Carsten Otte
2008-03-20 21:22 ` Heiko Carstens
2008-03-21 11:12 ` Carsten Otte
2008-03-21 14:06 ` Heiko Carstens
2008-03-21 14:33 ` Carsten Otte
2008-03-22 17:25 ` Heiko Carstens
2008-03-20 16:25 ` [RFC/PATCH 15/15] guest: virtio device support, and kvm hypercalls Carsten Otte
2008-03-21 0:24 ` Rusty Russell
2008-03-21 7:12 ` Carsten Otte
2008-03-21 8:15 ` Christian Borntraeger
2008-03-21 23:30 ` Rusty Russell [this message]
2008-03-22 7:36 ` Carsten Otte
2008-03-21 10:44 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803221030.49457.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=EHRHARDT@de.ibm.com \
--cc=arnd@arndb.de \
--cc=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=jblunck@suse.de \
--cc=jeroney@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=os@de.ibm.com \
--cc=rvdheij@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox