public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <marcelo@kvack.org>,
	kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Re: [Qemu-devel] [PATCH] QEMU: fsync AIO writes on flush request
Date: Fri, 28 Mar 2008 17:00:39 +0000	[thread overview]
Message-ID: <200803281700.40420.paul@codesourcery.com> (raw)
In-Reply-To: <20080328165941.GA19155@dmt>

> > Surely you should be using the normal aio notification to wait for the
> > aio_fsync to complete before reporting success to the device.
>
> qemu_aio_flush() will wait for all pending AIO requests (including
> aio_fsync) to complete.

Then why do you need to separate fdatasync?

Paul

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

  reply	other threads:[~2008-03-28 17:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28 15:05 [PATCH] QEMU: fsync AIO writes on flush request Marcelo Tosatti
2008-03-28 15:07 ` [Qemu-devel] " Jamie Lokier
2008-03-28 16:31   ` Marcelo Tosatti
2008-03-28 16:40     ` Paul Brook
2008-03-28 16:59       ` Marcelo Tosatti
2008-03-28 17:00         ` Paul Brook [this message]
2008-03-28 18:13           ` Marcelo Tosatti
2008-03-29  1:17             ` Jamie Lokier
2008-03-29  2:02               ` Paul Brook
2008-03-29  2:11                 ` Jamie Lokier
2008-03-29  2:43                   ` Paul Brook
2008-03-28 18:03     ` Jamie Lokier
2008-03-28 18:36       ` Marcelo Tosatti
2008-03-29  1:09         ` Jamie Lokier
2008-03-29  6:49           ` Marcelo Tosatti
2008-03-28 17:25 ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803281700.40420.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=marcelo@kvack.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox