From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] QEMU: fsync AIO writes on
	flush request
Date: Fri, 28 Mar 2008 17:00:39 +0000
Message-ID: <200803281700.40420.paul@codesourcery.com>
References: <20080328150517.GA18077@dmt>
	<200803281640.55185.paul@codesourcery.com>
	<20080328165941.GA19155@dmt>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <marcelo@kvack.org>,
	kvm-devel <kvm-devel@lists.sourceforge.net>
To: qemu-devel@nongnu.org
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <20080328165941.GA19155@dmt>
Content-Disposition: inline
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

> > Surely you should be using the normal aio notification to wait for the
> > aio_fsync to complete before reporting success to the device.
>
> qemu_aio_flush() will wait for all pending AIO requests (including
> aio_fsync) to complete.

Then why do you need to separate fdatasync?

Paul

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace