[ofa-general] Re: EMM: Fixup return value handling of emm_notify()

Christoph Lameter
2008-04-02T21:33:51Z

On Wed, 2 Apr 2008, Andrea Arcangeli wrote:

> but anyway it's silly to be hardwired to such an interface that worst
> of all requires switch statements instead of proper pointer to
> functions and a fixed set of parameters and retval semantics for all
> methods.

The EMM API with a single callback is the simplest approach at this point.
A common callback for all operations allows the driver to implement common
entry and exit code as seen in XPMem.

I guess we can complicate this more by switching to a different API or
adding additional emm_xxx() callback if need be but I really want to have
a strong case for why this would be needed. There is the danger of
adding frills with special callbacks in this and that situation that could
make the notifier complicated and specific to a certain usage scenario.

Having this generic simple interface will hopefully avoid such things.