From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@qumranet.com>, Dor Laor <dor.laor@gmail.com>
Cc: kvm-devel@lists.sourceforge.net, Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 2/3] QEMU/KVM: add function to handle signals
Date: Wed, 02 Apr 2008 20:20:15 -0300 [thread overview]
Message-ID: <20080402233312.210339972@localhost.localdomain> (raw)
In-Reply-To: 20080402232013.121684903@localhost.localdomain
[-- Attachment #1: io-thread-sig --]
[-- Type: text/plain, Size: 1946 bytes --]
SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore
(thats also true for SIGIO on tap fd, which runs host_alarm_handler
unnecessarily).
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: kvm-userspace.io/qemu/qemu-kvm.c
===================================================================
--- kvm-userspace.io.orig/qemu/qemu-kvm.c
+++ kvm-userspace.io/qemu/qemu-kvm.c
@@ -163,13 +163,30 @@ static int has_work(CPUState *env)
return kvm_arch_has_work(env);
}
+static int kvm_process_signal(int si_signo)
+{
+ struct sigaction sa;
+
+ switch (si_signo) {
+ case SIGUSR2:
+ pthread_cond_signal(&qemu_aio_cond);
+ break;
+ case SIGALRM:
+ case SIGIO:
+ sigaction(si_signo, NULL, &sa);
+ sa.sa_handler(si_signo);
+ break;
+ }
+
+ return 1;
+}
+
static int kvm_eat_signal(struct qemu_kvm_signal_table *waitset, CPUState *env,
int timeout)
{
struct timespec ts;
int r, e, ret = 0;
siginfo_t siginfo;
- struct sigaction sa;
ts.tv_sec = timeout / 1000;
ts.tv_nsec = (timeout % 1000) * 1000000;
@@ -184,13 +201,9 @@ static int kvm_eat_signal(struct qemu_kv
printf("sigtimedwait: %s\n", strerror(e));
exit(1);
}
- if (r != -1) {
- sigaction(siginfo.si_signo, NULL, &sa);
- sa.sa_handler(siginfo.si_signo);
- if (siginfo.si_signo == SIGUSR2)
- pthread_cond_signal(&qemu_aio_cond);
- ret = 1;
- }
+ if (r != -1)
+ ret = kvm_process_signal(siginfo.si_signo);
+
if (env && vcpu_info[env->cpu_index].stop) {
vcpu_info[env->cpu_index].stop = 0;
vcpu_info[env->cpu_index].stopped = 1;
--
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2008-04-02 23:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 23:20 [patch 0/3] separate thread for IO handling V3 Marcelo Tosatti
2008-04-02 23:20 ` [patch 1/3] QEMU/KVM: separate thread for IO handling Marcelo Tosatti
2008-04-02 23:20 ` Marcelo Tosatti [this message]
2008-04-02 23:20 ` [patch 3/3] QEMU/KVM: notify IO thread of pending bhs Marcelo Tosatti
2008-04-03 10:24 ` [patch 0/3] separate thread for IO handling V3 Avi Kivity
2008-04-03 12:46 ` Avi Kivity
2008-04-03 15:26 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-03-27 15:09 [patch 0/3] QEMU dedicated IO thread Marcelo Tosatti
2008-03-27 15:09 ` [patch 2/3] QEMU/KVM: add function to handle signals Marcelo Tosatti
2008-03-27 15:25 ` Avi Kivity
2008-03-27 15:57 ` Marcelo Tosatti
2008-03-27 15:57 ` Avi Kivity
2008-03-27 16:55 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402233312.210339972@localhost.localdomain \
--to=mtosatti@redhat.com \
--cc=avi@qumranet.com \
--cc=dor.laor@gmail.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox