From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 3/4] QEMU/KVM: ignore SIG_IPI signals in
	userspace
Date: Mon, 7 Apr 2008 17:26:24 -0300
Message-ID: <20080407202624.GA4254@dmt>
References: <20080405182246.761430758@localhost.localdomain>
	<20080405182320.098125884@localhost.localdomain>
	<47F8949B.8000409@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net
To: Avi Kivity <avi@qumranet.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
Content-Disposition: inline
In-Reply-To: <47F8949B.8000409@qumranet.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

On Sun, Apr 06, 2008 at 12:15:07PM +0300, Avi Kivity wrote:
> Marcelo Tosatti wrote:
> >Otherwise a signal can be received in userspace and a vcpu goes back
> >to the kernel while it should stay still.
> >
> >Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> >
> >Index: kvm-userspace.io/qemu/qemu-kvm.c
> >===================================================================
> >--- kvm-userspace.io.orig/qemu/qemu-kvm.c
> >+++ kvm-userspace.io/qemu/qemu-kvm.c
> >@@ -350,7 +350,6 @@ static void *ap_main_loop(void *_env)
> >     vcpu->env = env;
> >     vcpu->env->thread_id = kvm_get_thread_id();
> >     sigfillset(&signals);
> >-    sigdelset(&signals, SIG_IPI);
> >     sigprocmask(SIG_BLOCK, &signals, NULL);
> >     kvm_create_vcpu(kvm_context, env->cpu_index);
> >     kvm_qemu_init_env(env);
> >
> >  
> 
> Does this work with -no-kvm-irqchip?

Yes. SIG_IPI was blocked before the IO thread.

> I think we need to fix the kernel to handle random signals.  Otherwise 
> even attaching a debugger can change guest behavior (I think).

Well ptrace forces signals so SIGSTOP is delivered even though the child
has blocked them.

Attaching a debugger does change behaviour since SIGSTOP will send a
vcpu back to userspace.

Can you be more specific?


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone