From: Hollis Blanchard <hollisb@us.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel@lists.sourceforge.net, Carsten Otte <cotte@de.ibm.com>,
kvm-ia64-devel@lists.sourceforge.net,
Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 1/2] kvm-s390: provide get/set_mp_state stubs to fix compile error
Date: Wed, 16 Apr 2008 11:21:05 -0500 [thread overview]
Message-ID: <200804161121.05649.hollisb@us.ibm.com> (raw)
In-Reply-To: <1208354794.6122.12.camel@cotte.boeblingen.de.ibm.com>
By the way Marcelo, it would be polite to provide these stubs yourself to
avoid breaking the build on other architectures.
It looks like IA64 is still broken because of this.
--
Hollis Blanchard
IBM Linux Technology Center
On Wednesday 16 April 2008 09:06:34 Carsten Otte wrote:
> From: Christian Borntraeger <borntraeger@de.ibm.com>
>
> Since
>
> commit ded6fb24fb694bcc5f308a02ec504d45fbc8aaa6
> Author: Marcelo Tosatti <mtosatti@redhat.com>
> Date: Fri Apr 11 13:24:45 2008 -0300
> KVM: add ioctls to save/store mpstate
>
> kvm does not compile on s390.
> This patch provides ioctl stubs for s390 to make kvm.git compile again.
> As migration is not yet supported, the ioctl definitions are empty.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Carsten Otte <cotte@de.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> Index: kvm/arch/s390/kvm/kvm-s390.c
> ===================================================================
> --- kvm.orig/arch/s390/kvm/kvm-s390.c
> +++ kvm/arch/s390/kvm/kvm-s390.c
> @@ -414,6 +414,18 @@ int kvm_arch_vcpu_ioctl_debug_guest(stru
> return -EINVAL; /* not implemented yet */
> }
>
> +int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
> + struct kvm_mp_state *mp_state)
> +{
> + return -EINVAL; /* not implemented yet */
> +}
> +
> +int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu,
> + struct kvm_mp_state *mp_state)
> +{
> + return -EINVAL; /* not implemented yet */
> +}
> +
> static void __vcpu_run(struct kvm_vcpu *vcpu)
> {
> memcpy(&vcpu->arch.sie_block->gg14, &vcpu->arch.guest_gprs[14], 16);
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
> Don't miss this year's exciting event. There's still time to save $100.
> Use priority code J8TL2D2.
>
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-16 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1208354539.6122.6.camel@cotte.boeblingen.de.ibm.com>
2008-04-16 14:06 ` [PATCH 1/2] kvm-s390: provide get/set_mp_state stubs to fix compile error Carsten Otte
2008-04-16 16:21 ` Hollis Blanchard [this message]
2008-04-16 17:44 ` Marcelo Tosatti
2008-04-17 8:18 ` Avi Kivity
2008-04-16 14:06 ` [PATCH 2/2] virtio-s390: Change virtio interrupt definitions to follow architecture Carsten Otte
2008-04-17 8:44 ` Avi Kivity
2008-04-17 9:14 ` Christian Borntraeger
2008-04-17 9:27 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804161121.05649.hollisb@us.ibm.com \
--to=hollisb@us.ibm.com \
--cc=avi@qumranet.com \
--cc=cotte@de.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ia64-devel@lists.sourceforge.net \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox