public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Soren Hansen <soren@ubuntu.com>
To: kvm-devel@lists.sourceforge.net
Subject: Re: 32-bit binaries failing in 64 bit guests after	using vmport
Date: Mon, 21 Apr 2008 17:20:37 +0200	[thread overview]
Message-ID: <20080421152037.GD25786@ralph.linux2go.dk> (raw)
In-Reply-To: <480C9BD5.7000402@codemonkey.ws>


[-- Attachment #1.1: Type: text/plain, Size: 1616 bytes --]

On Mon, Apr 21, 2008 at 08:51:17AM -0500, Anthony Liguori wrote:
>> We're releasing on Thursday, and I needed a quick fix, so I reverted
>> the calls to kvm_{save,load}_registers in vmport_ioport_read to the
>> old code that simply saved the eax, ebx, ecx, edx, esi, and edi
>> registers, but I'm supposing kvm_{load,save}_registers really should
>> work here.

/me sighs very deeply

Ok, first chance I get, I'm signing up for "Patch management 101". :( I
got some tests mixed around, so it failing is actually dependent on
whether EIP (not LSTAR as I originally thought) is restored or not.

I have a patch that fixes it, but I need to work a few things out first
before I submit it.

> Ah, you may have missed the fix that updated the KVM load/save
> functions  to deal with the in-kernel APIC.

Indeed.

> It turns out, vmmouse was horribly broken with SMP guests too.  See
>
> commit 9949bd84ac4dfdfc60b2974557819637b8719911
> Author: Anthony Liguori <aliguori@us.ibm.com>
> Date:   Thu Apr 3 18:37:16 2008 -0500
>
> commit 5208ce19dca268f84a2b9441c2fbb6129161e44c
> Author: Marcelo Tosatti <mtosatti@redhat.com>
> Date:   Thu Apr 3 20:24:37 2008 -0300

I did my tests using kvm-65 userland and kernel, so these two should
already be included, afaics.  

> commit 85a67aa2a1b942ddccfcbd625d280869367edc95
> Author: Marcelo Tosatti <mtosatti@redhat.com>
> Date:   Fri Apr 11 13:24:41 2008 -0300

This did not change anything for me.

-- 
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 320 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

[-- Attachment #3: Type: text/plain, Size: 158 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

      reply	other threads:[~2008-04-21 15:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21  7:08 32-bit binaries failing in 64 bit guests after using vmport Soren Hansen
2008-04-21 13:51 ` Anthony Liguori
2008-04-21 15:20   ` Soren Hansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080421152037.GD25786@ralph.linux2go.dk \
    --to=soren@ubuntu.com \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox