From: Rusty Russell <rusty@rustcorp.com.au>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Hollis Blanchard <hollisb@us.ibm.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH] virtio: change config to guest endian.
Date: Wed, 23 Apr 2008 00:31:35 +1000 [thread overview]
Message-ID: <200804230031.35760.rusty@rustcorp.com.au> (raw)
In-Reply-To: <480DCA88.4010407@qumranet.com>
On Tuesday 22 April 2008 21:22:48 Avi Kivity wrote:
> > The virtio config space was originally chosen to be little-endian,
> > because we thought the config might be part of the PCI config space
> > for virtio_pci. It's actually a separate mmio region, so that
> > argument holds little water; as only x86 is currently using the virtio
> > mechanism, we can change this (but must do so now, before the
> > impending s390 and ppc merges).
>
> This will probably annoy Hollis which has guests that can go both ways.
Yes, I discussed this with Hollis. But the virtio rings themselves already
have this issue: we don't do any endian conversion on them and assume
they're "our" endian in the guest.
We may still regret not doing *everything* little-endian, but this doesn't
make it worse.
Thanks,
Rusty.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-22 14:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 3:57 [RFC PATCH] virtio: change config to guest endian Rusty Russell
2008-04-22 7:44 ` Christian Borntraeger
2008-04-22 14:40 ` Rusty Russell
2008-04-22 11:22 ` Avi Kivity
2008-04-22 14:31 ` Rusty Russell [this message]
2008-04-22 20:29 ` [kvm-devel] " Hollis Blanchard
2008-04-22 21:05 ` Rusty Russell
2008-04-22 22:08 ` Hollis Blanchard
2008-04-22 22:13 ` Anthony Liguori
2008-04-22 22:33 ` Hollis Blanchard
2008-04-22 23:53 ` Hollis Blanchard
2008-04-22 16:21 ` [kvm-devel] " Hollis Blanchard
2008-04-23 10:55 ` Christian Borntraeger
2008-04-23 12:38 ` Avi Kivity
2008-04-23 12:47 ` Christian Borntraeger
2008-04-23 15:53 ` [kvm-devel] " Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804230031.35760.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox