From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [RFC PATCH] virtio: change config to guest endian. Date: Wed, 23 Apr 2008 00:31:35 +1000 Message-ID: <200804230031.35760.rusty@rustcorp.com.au> References: <200804221357.34571.rusty@rustcorp.com.au> <480DCA88.4010407@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Christian Borntraeger , Hollis Blanchard , virtualization@lists.linux-foundation.org To: Avi Kivity Return-path: In-Reply-To: <480DCA88.4010407@qumranet.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org On Tuesday 22 April 2008 21:22:48 Avi Kivity wrote: > > The virtio config space was originally chosen to be little-endian, > > because we thought the config might be part of the PCI config space > > for virtio_pci. It's actually a separate mmio region, so that > > argument holds little water; as only x86 is currently using the virtio > > mechanism, we can change this (but must do so now, before the > > impending s390 and ppc merges). > > This will probably annoy Hollis which has guests that can go both ways. Yes, I discussed this with Hollis. But the virtio rings themselves already have this issue: we don't do any endian conversion on them and assume they're "our" endian in the guest. We may still regret not doing *everything* little-endian, but this doesn't make it worse. Thanks, Rusty. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone