public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net,
	Hollis Blanchard <hollisb@us.ibm.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH] virtio: change config to guest endian.
Date: Wed, 23 Apr 2008 14:47:08 +0200	[thread overview]
Message-ID: <200804231447.08196.borntraeger@de.ibm.com> (raw)
In-Reply-To: <480F2DD5.7080007@qumranet.com>

Am Mittwoch, 23. April 2008 schrieb Avi Kivity:
> >>  #define VIRTIO_CONFIG_S_FAILED		0x80
> >>
> >>  #ifdef __KERNEL__
> >> -struct virtio_device;
> >> +#include <linux/virtio.h>
> >>     
> >
> > I just realized, that this breaks make headers_check as we dont export 
> > virtio.h (and we dont want to export it as it relies on scatterlist.h).
> >
> >   
> 
> It's guarded by a #ifdef __KERNEL__, so it should be alright.

Yes, you are right. Thanks

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

  reply	other threads:[~2008-04-23 12:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22  3:57 [RFC PATCH] virtio: change config to guest endian Rusty Russell
2008-04-22  7:44 ` Christian Borntraeger
2008-04-22 14:40   ` Rusty Russell
2008-04-22 11:22 ` Avi Kivity
2008-04-22 14:31   ` Rusty Russell
2008-04-22 20:29     ` [kvm-devel] " Hollis Blanchard
2008-04-22 21:05       ` Rusty Russell
2008-04-22 22:08         ` Hollis Blanchard
2008-04-22 22:13           ` Anthony Liguori
2008-04-22 22:33             ` Hollis Blanchard
2008-04-22 23:53             ` Hollis Blanchard
2008-04-22 16:21   ` [kvm-devel] " Hollis Blanchard
2008-04-23 10:55 ` Christian Borntraeger
2008-04-23 12:38   ` Avi Kivity
2008-04-23 12:47     ` Christian Borntraeger [this message]
2008-04-23 15:53   ` [kvm-devel] " Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804231447.08196.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=avi@qumranet.com \
    --cc=hollisb@us.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox