From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrea Arcangeli <andrea@qumranet.com>
Subject: [ofa-general] Re: [PATCH 01 of 12] Core of mmu notifiers
Date: Wed, 23 Apr 2008 20:37:18 +0200
Message-ID: <20080423183718.GL24536@duo.random>
References: <ea87c15371b1bd49380c.1208872277@duo.random>
	<Pine.LNX.4.64.0804221315160.3640@schroedinger.engr.sgi.com>
	<20080422223545.GP24536@duo.random>
	<20080422230727.GR30298@sgi.com>
	<20080423133619.GV24536@duo.random>
	<20080423144747.GU30298@sgi.com>
	<20080423155940.GY24536@duo.random>
	<Pine.LNX.4.64.0804231105090.12373@schroedinger.engr.sgi.com>
	<20080423181928.GI24536@duo.random>
	<Pine.LNX.4.64.0804231122410.12373@schroedinger.engr.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nick Piggin <npiggin@suse.de>, Rusty Russell <rusty@rustcorp.com.au>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>, kvm-devel@lists.sourceforge.net,
	Kanoj Sarcar <kanojsarcar@yahoo.com>, Roland Dreier <rdreier@cisco.com>,
	Jack Steiner <steiner@sgi.com>, linux-kernel@vger.kernel.org,
	Avi Kivity <avi@qumranet.com>, linux-mm@kvack.org,
	Robin Holt <holt@sgi.com>, general@lists.openfabrics.org,
	Hugh Dickins <hugh@veritas.com>, akpm@linux-foundation.org
To: Christoph Lameter <clameter@sgi.com>
Return-path: <general-bounces@lists.openfabrics.org>
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0804231122410.12373@schroedinger.engr.sgi.com>
List-Unsubscribe: <http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general>,
	<mailto:general-request@lists.openfabrics.org?subject=unsubscribe>
List-Archive: <http://lists.openfabrics.org/pipermail/general>
List-Post: <mailto:general@lists.openfabrics.org>
List-Help: <mailto:general-request@lists.openfabrics.org?subject=help>
List-Subscribe: <http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general>,
	<mailto:general-request@lists.openfabrics.org?subject=subscribe>
Sender: general-bounces@lists.openfabrics.org
Errors-To: general-bounces@lists.openfabrics.org
List-Id: kvm.vger.kernel.org

On Wed, Apr 23, 2008 at 11:27:21AM -0700, Christoph Lameter wrote:
> There is a potential issue in move_ptes where you call 
> invalidate_range_end after dropping i_mmap_sem whereas my patches did the 
> opposite. Mmap_sem saves you there?

Yes, there's really no risk of races in this area after introducing
mm_lock, any place that mangles over ptes and doesn't hold any of the
three locks is buggy anyway. I appreciate the audit work (I also did
it and couldn't find bugs but the more eyes the better).