public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: libkvm: initialize no_pit_creation
Date: Fri, 25 Apr 2008 21:53:43 -0300	[thread overview]
Message-ID: <20080426005343.GA11096@dmt> (raw)


Valgrind caught this:

==11754== Conditional jump or move depends on uninitialised value(s)
==11754==    at 0x50C9BC: kvm_create_pit (libkvm-x86.c:153)
==11754==    by 0x50CA7F: kvm_arch_create (libkvm-x86.c:178)
==11754==    by 0x50AB31: kvm_create (libkvm.c:383)
==11754==    by 0x4EE691: kvm_qemu_create_context (qemu-kvm.c:616)
==11754==    by 0x412031: main (vl.c:9653)

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>


diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
index 329f29f..adf09a5 100644
--- a/libkvm/libkvm.c
+++ b/libkvm/libkvm.c
@@ -249,6 +249,7 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks,
 	kvm->opaque = opaque;
 	kvm->dirty_pages_log_all = 0;
 	kvm->no_irqchip_creation = 0;
+	kvm->no_pit_creation = 0;
 
 	return kvm;
  out_close:

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

             reply	other threads:[~2008-04-26  0:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26  0:53 Marcelo Tosatti [this message]
2008-04-27 12:50 ` libkvm: initialize no_pit_creation Avi Kivity
2008-04-28 17:58   ` Jan Kiszka
2008-05-02 11:22     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080426005343.GA11096@dmt \
    --to=mtosatti@redhat.com \
    --cc=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox