[ofa-general] Re: [PATCH 02 of 12] Fix ia64 compilation failure because of common code include bug

Robin Holt
2008-04-22T23:07:58Z

On Wed, Apr 23, 2008 at 12:43:52AM +0200, Andrea Arcangeli wrote:
> On Tue, Apr 22, 2008 at 01:22:55PM -0700, Christoph Lameter wrote:
> > Looks like this is not complete. There are numerous .h files missing which
> > means that various structs are undefined (fs.h and rmap.h are needed
> > f.e.) which leads to surprises when dereferencing fields of these struct.
> >
> > It seems that mm_types.h is expected to be included only in certain
> > contexts. Could you make sure to include all necessary .h files? Or add
> > some docs to clarify the situation here.
>
> Robin, what other changes did you need to compile? I only did that one
> because I didn't hear any more feedback from you after I sent that
> patch, so I assumed it was enough.

It was perfect. Nothing else was needed.

Thanks,
Robin