From mboxrd@z Thu Jan  1 00:00:00 1970
From: Muli Ben-Yehuda <muli@il.ibm.com>
Subject: Re: [PATCH] x86 DMA: Handle devices assigned to the guest by the
	host
Date: Wed, 30 Apr 2008 09:29:41 +0300
Message-ID: <20080430062940.GM7378@il.ibm.com>
References: <1209465451-3758-1-git-send-email-amit.shah@qumranet.com> <1209465451-3758-2-git-send-email-amit.shah@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm-devel@lists.sourceforge.net,
	virtualization@lists.linux-foundation.org,
	Ben-Ami Yassour1 <BENAMI@il.ibm.com>, gcosta@redhat.com,
	chrisw@redhat.com, dor.laor@qumranet.com, allen.m.kay@intel.com,
	avi@qumranet.com, linux-kernel@vger.kernel.org
To: Amit Shah <amit.shah@qumranet.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1758716AbYD3G1Z@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1209465451-3758-2-git-send-email-amit.shah@qumranet.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, Apr 29, 2008 at 01:37:29PM +0300, Amit Shah wrote:

> dma_alloc_coherent() doesn't call dma_ops->alloc_coherent in case no
> IOMMU translations are necessary.

I always thought this was a huge wart in the x86-64 DMA ops. Would
there be strong resistance to fixing it so that alloc_coherent
matches the way the other ops are used? This will eliminate the need
for this patch and will make other DMA ops implementations saner.

Cheers,
Muli