From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 1/4] Replace SIGUSR1 in io-thread with eventfd() (v2)
Date: Tue, 6 May 2008 16:46:09 -0300 [thread overview]
Message-ID: <20080506194609.GA18171@dmt> (raw)
In-Reply-To: <1209995235-32544-1-git-send-email-aliguori@us.ibm.com>
Looks good (the whole series).
Needs some good testing of course... Have you tested migration/loadvm?
On Mon, May 05, 2008 at 08:47:12AM -0500, Anthony Liguori wrote:
> It's a little odd to use signals to raise a notification on a file descriptor
> when we can just work directly with a file descriptor instead. This patch
> converts the SIGUSR1 based notification in the io-thread to instead use an
> eventfd file descriptor. If eventfd isn't available, we use a pipe() instead.
>
> The benefit of using eventfd is that multiple notifications will be batched
> into a signal IO event.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-05-06 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 13:47 [PATCH 1/4] Replace SIGUSR1 in io-thread with eventfd() (v2) Anthony Liguori
2008-05-05 13:47 ` [PATCH 2/4] Use signalfd() in io-thread (v2) Anthony Liguori
2008-05-05 13:47 ` [PATCH 3/4] Interrupt io thread in qemu_set_fd_handler2 (v2) Anthony Liguori
2008-05-05 13:47 ` [PATCH 4/4] Only select once per-main_loop iteration (v2) Anthony Liguori
2008-05-06 19:46 ` Marcelo Tosatti [this message]
2008-05-06 19:44 ` [PATCH 1/4] Replace SIGUSR1 in io-thread with eventfd() (v2) Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506194609.GA18171@dmt \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox