From: Aurelien Jarno <aurelien@aurel32.net>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] Fix e1000 can_receive handler
Date: Thu, 8 May 2008 15:26:46 +0200 [thread overview]
Message-ID: <20080508132646.GA27727@volta.aurel32.net> (raw)
In-Reply-To: <1210196458-17069-1-git-send-email-aliguori@us.ibm.com>
On Wed, May 07, 2008 at 04:40:58PM -0500, Anthony Liguori wrote:
> The current logic of the can_receive handler is to allow packets whenever the
> receiver is disabled or when there are descriptors available in the ring.
>
> I think the logic ought to be to allow packets whenever the receiver is enabled
> and there are descriptors available in the ring.
The current behaviour is actually correct, this is the way QEMU works:
when the card is stopped, it should always accept packets, and then
discard them.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-05-08 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 21:40 [PATCH] Fix e1000 can_receive handler Anthony Liguori
2008-05-08 13:26 ` Aurelien Jarno [this message]
2008-05-08 14:03 ` Anthony Liguori
2008-05-08 17:02 ` Avi Kivity
2008-05-08 17:21 ` Avi Kivity
2008-05-08 18:41 ` Anthony Liguori
2008-05-09 7:47 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508132646.GA27727@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox