From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aurelien Jarno Subject: Re: [PATCH] Fix e1000 can_receive handler Date: Thu, 8 May 2008 15:26:46 +0200 Message-ID: <20080508132646.GA27727@volta.aurel32.net> References: <1210196458-17069-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Avi Kivity To: Anthony Liguori Return-path: Content-Disposition: inline In-Reply-To: <1210196458-17069-1-git-send-email-aliguori@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org On Wed, May 07, 2008 at 04:40:58PM -0500, Anthony Liguori wrote: > The current logic of the can_receive handler is to allow packets whenever the > receiver is disabled or when there are descriptors available in the ring. > > I think the logic ought to be to allow packets whenever the receiver is enabled > and there are descriptors available in the ring. The current behaviour is actually correct, this is the way QEMU works: when the card is stopped, it should always accept packets, and then discard them. -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone