From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: KVM: kvm_vcpu_block task state race Date: Fri, 9 May 2008 11:21:01 -0300 Message-ID: <20080509142101.GA11591@dmt> References: <20080508224701.GA6175@dmt> <4823FFFF.3040005@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <4823FFFF.3040005@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org On Fri, May 09, 2008 at 10:40:47AM +0300, Avi Kivity wrote: > >Unfortunately it can't use wait_event_interruptible() due to > >vcpu_put/vcpu_load. > > > > > > schedule() will call vcpu_put()/vcpu_load() for us through preempt > notifiers. I feel a little uneasy about it, but no concreate reason why > not to rely on it. The preempt notifiers hook call kvm_arch_vcpu_load / kvm_arch_vcpu_put, which won't unlock the vcpu mutex, right? I worry about a possible deadlock where some other operation that requires the vcpu mutex happens but the vcpu thread itself is in hlt. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone