From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: KVM: kvm_vcpu_block task state race Date: Wed, 14 May 2008 02:21:07 -0300 Message-ID: <20080514052107.GA11898@dmt> References: <20080508224701.GA6175@dmt> <4823FFFF.3040005@qumranet.com> <20080509142101.GA11591@dmt> <48246935.50603@qumranet.com> <20080509192208.GA13579@dmt> <482701FE.2000707@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <482701FE.2000707@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org On Sun, May 11, 2008 at 05:26:06PM +0300, Avi Kivity wrote: > >So do you want to give wait_event_interruptible() a try or wait for that > >change until userspace never issues vcpu ioctl's to a possibly busy vcpu > >(and go with the patch above)? > > > > Do we have anything critical that issues vcpu ioctls outside its > thread? While I much prefer wait_event_interruptible(), I don't want to > break existing userspace. Well debugging can be critical, so IMO better avoid wait_event_interruptible() for now. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/