public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollisb@us.ibm.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: Avi Kivity <avi@qumranet.com>,
	kvm@vger.kernel.org, "Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [PATCH 1/2][RFC][v2] kvm: Batch writes to MMIO
Date: Tue, 20 May 2008 10:43:08 -0500	[thread overview]
Message-ID: <200805201043.09002.hollisb@us.ibm.com> (raw)
In-Reply-To: <1211269182.4314.4.camel@frecb07144>

On Tuesday 20 May 2008 02:39:42 Laurent Vivier wrote:
> Le lundi 19 mai 2008 à 22:04 -0500, Hollis Blanchard a écrit :
> > On Monday 19 May 2008 03:36:30 Laurent Vivier wrote:
> > > Thank you for your comments.
> > > 
> > > I agree with all.
> > > 
> > > I'll move my code to mulator_write_emulated_onepage().
> > > I'll use kvm_io_device mechanism: is there an existing ioctl() to
> > > register MMIO zone ?
> > > I'll add a KVM_CAP_
> > 
> > Does that mean you'll move "batch" from kvm_vcpu_arch to kvm_vcpu as well?
> 
> No, except if people like you (non-x86 developers) asks for it.
> (but I can't compile/test).

Please include it in the existing CONFIG_HAS_IOMEM block inside struct 
kvm_vcpu.

Most of the new functions you've introduced should similarly go into 
kvm_main.c, since there is nothing x86-specific in them.

-- 
Hollis Blanchard
IBM Linux Technology Center

  reply	other threads:[~2008-05-20 15:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15 13:52 [PATCH 0/2][RFC][v2] Batch writes to MMIO Laurent Vivier
2008-05-15 13:52 ` [PATCH 1/2][RFC][v2] kvm: " Laurent Vivier
2008-05-15 13:52   ` [PATCH 2/2][RFC][v2] kvm-userspace: " Laurent Vivier
     [not found]   ` <482FDD1E.2090304@qumranet.com>
2008-05-19  8:36     ` [PATCH 1/2][RFC][v2] kvm: " Laurent Vivier
2008-05-19 10:21       ` Avi Kivity
2008-05-20  3:04       ` Hollis Blanchard
2008-05-20  7:39         ` Laurent Vivier
2008-05-20 15:43           ` Hollis Blanchard [this message]
2008-05-20 15:52             ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805201043.09002.hollisb@us.ibm.com \
    --to=hollisb@us.ibm.com \
    --cc=Laurent.Vivier@bull.net \
    --cc=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox