From mboxrd@z Thu Jan 1 00:00:00 1970 From: "M. Warner Losh" Subject: Re: [Qemu-devel] [PATCH 03/14] QEMU: Fill in PCI subsystem vendor id for e1000 Date: Mon, 26 May 2008 12:36:13 -0600 (MDT) Message-ID: <20080526.123613.-1676919979.imp@bsdimp.com> References: <1211798213-4187-4-git-send-email-amit.shah@qumranet.com> <1211798213-4187-5-git-send-email-amit.shah@qumranet.com> <1211798213-4187-6-git-send-email-amit.shah@qumranet.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: qemu-devel@nongnu.org, amit.shah@qumranet.com Return-path: Received: from bsdimp.com ([199.45.160.85]:63216 "EHLO harmony.bsdimp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753220AbYEZSnR (ORCPT ); Mon, 26 May 2008 14:43:17 -0400 In-Reply-To: <1211798213-4187-6-git-send-email-amit.shah@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Picking a random one to reply to: In message: <1211798213-4187-6-git-send-email-amit.shah@qumranet.com> Amit Shah writes: : The subsystem vendor ID shouldn't be 0x0 or 0xffff according : to the PCI spec Old versions of the spec allowed for these values. Many older PCI devices have 0xffff as their subvendor ID. This is especially true for video cards... I'd be cautious in applying these patches, since QEMU tends to emulate very old devices in some cases... Warner