From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [PATCH 1/6] simplify cpu_exec
Date: Tue, 27 May 2008 16:33:50 +0100
Message-ID: <200805271633.51342.paul@codesourcery.com>
References: <1211901505-30519-1-git-send-email-gcosta@redhat.com>
	<1211901505-30519-2-git-send-email-gcosta@redhat.com>
Reply-To: qemu-devel@nongnu.org
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Glauber Costa <gcosta@redhat.com>
To: qemu-devel@nongnu.org
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <1211901505-30519-2-git-send-email-gcosta@redhat.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

> +void cpu_load_flags(CPUState *env);
> +void cpu_put_flags(CPUState *env);

These really need a comment saying what they do. The names are not at all 
intuitive. Also, why load/put? I'd expect load/save/store or get/put.

> +#if defined(reg_REGWPTR)
> +static uint32_t *saved_regwptr;
> +#endif

Eww. You've replaced reasonably self contained local code with a global 
variable hidden deep in target specific code. I plan on adding multithreaded 
qemu support soon, so this is a non-starter.

Paul